Update standalone activity protos #8549
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
dandavison
force-pushed
the
update-protos
branch
from
b24b95c to
cac496a
Compare
bergundy
approved these changes
Oct 27, 2025
Member
bergundy
left a comment
bergundy
left a comment
There was a problem hiding this comment.
Please note my comment below.
| "/temporal.api.workflowservice.v1.WorkflowService/UpdateWorkflowExecution": 1, | ||
| "/temporal.api.workflowservice.v1.WorkflowService/GetWorkflowExecutionHistory": 1, | ||
| "/temporal.api.workflowservice.v1.WorkflowService/PollNexusTaskQueue": 1, | ||
| // TODO: Map to PollActivityResult if request is long-polling |
Member
There was a problem hiding this comment.
I put this TODO here to make sure that we categorize long poll requests correctly. This request isn't always a long poll and needs some pre-processing to categorize.
Contributor
Author
There was a problem hiding this comment.
Ah I see the special treatment of GetWorkflowExecutionHistory now. Added a TODO back in.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
dandavison
force-pushed
the
update-protos
branch
from
405e5d1 to
cb5f326
Compare
dandavison
force-pushed
the
update-protos
branch
from
cb5f326 to
21cdb37
Compare
dandavison
added a commit
that referenced
this pull request
Oct 30, 2025
Update to latest protos from temporalio/api#640
dandavison
added a commit
that referenced
this pull request
Dec 19, 2025
Update to latest protos from temporalio/api#640
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update to latest protos from temporalio/api#640
Removes
WorkerHeartbeat-- this has already been done inmain(2403695) but we are not currently rebased onmain.Note
Adds PollActivityExecution across server and client layers while removing DescribeActivityExecution and GetActivityExecutionResult; updates quotas/metadata/interceptors/mocks and bumps Temporal API dep.
PollActivityExecutiontoFrontendHandlerand client wrappers (client_gen,metric_client_gen,retryable_client_gen), log tags, redirection maps, and tests.DescribeActivityExecutionandGetActivityExecutionResultfrom clients, metrics, retryable clients, redirection maps, metadata, log tags, and mocks.PollActivityExecutionas long-running and set priority (P4); update long-poll docs.PollActivityExecutionas polling-capable incommon/api/metadata.go.PollWorkflowTaskQueue.go.temporal.io/apidependency; cleangetprotoimport map (removeenums/v1/id.proto).Written by Cursor Bugbot for commit 21cdb37. This will update automatically on new commits. Configure here.